Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to meilisearch backup-restore-sidecar support. #143

Merged
merged 8 commits into from
Sep 26, 2023

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Sep 20, 2023

@vknabel
Copy link
Contributor

vknabel commented Sep 25, 2023

During make up, I got an error: ERROR: invalid reference format

❯ make up            
Obtaining release vector variables...
No kind clusters found.
Creating cluster "metal-control-plane" ...
 ✓ Ensuring node image (kindest/node:v1.27.3) 🖼 
 ✓ Preparing nodes 📦  
 ✓ Writing configuration 📜 
 ✓ Starting control-plane 🕹️ 
 ✓ Installing CNI 🔌 
 ✓ Installing StorageClass 💾 
Set kubectl context to "kind-metal-control-plane"
You can now use your cluster with:

kubectl cluster-info --context kind-metal-control-plane --kubeconfig /home/vknabel/dev/ms/mini-lab/.kubeconfig

Not sure what to do next? 😅  Check out https://kind.sigs.k8s.io/docs/user/quick-start/
# docker pull ghcr.io/metal-stack/mini-lab-vms:latest
INFO[0000] Containerlab v0.25.1 started                 
INFO[0000] Parsing & checking topology file: mini-lab.cumulus.yaml 
INFO[0000] Removing /home/vknabel/dev/ms/mini-lab/clab-mini-lab directory... 
INFO[0000] Creating lab directory: /home/vknabel/dev/ms/mini-lab/clab-mini-lab 
INFO[0000] Creating container: "vms"                    
INFO[0002] Networking is handled by "docker-bridge"     
INFO[0002] Started Firecracker VM "91ab0c5d077b6d42" in a container with ID "963b9defc90d876129e57d0f929b7db26af16ccde75d65b963d533936756cebd" 
INFO[0002] Creating virtual wire: leaf01:swp1 <--> vms:lan0 
INFO[0002] Creating virtual wire: leaf01:swp2 <--> vms:lan2 
INFO[0002] Creating virtual wire: leaf01:swp3 <--> vms:lan4 
INFO[0003] Networking is handled by "docker-bridge"     
INFO[0003] Started Firecracker VM "e7e6e895b1a127a8" in a container with ID "07e083e89d92b775715c1793d45cc2e72ae7260f5946526af977a53592dc755a" 
INFO[0003] Creating virtual wire: leaf02:swp2 <--> vms:lan3 
INFO[0003] Creating virtual wire: leaf02:swp3 <--> vms:lan5 
INFO[0003] Creating virtual wire: leaf02:swp1 <--> vms:lan1 
INFO[0004] Adding containerlab host entries to /etc/hosts file 
INFO[0004] 🎉 New containerlab version 0.45.1 is available! Release notes: https://containerlab.dev/rn/0.45/#0451
Run 'containerlab version upgrade' to upgrade or go check other installation options at https://containerlab.dev/install/ 
+---+--------+--------------+-----------------------------------------+-------+---------+---------------+--------------+
| # |  Name  | Container ID |                  Image                  | Kind  |  State  | IPv4 Address  | IPv6 Address |
+---+--------+--------------+-----------------------------------------+-------+---------+---------------+--------------+
| 1 | leaf01 | 963b9defc90d | docker.io/networkop/cx:3.7.0            | cvx   | running | 172.17.0.3/24 | N/A          |
| 2 | leaf02 | 07e083e89d92 | docker.io/networkop/cx:3.7.0            | cvx   | running | 172.17.0.4/24 | N/A          |
| 3 | vms    | b74a9cb9ba28 | ghcr.io/metal-stack/mini-lab-vms:latest | linux | running | 172.17.0.2/16 | N/A          |
+---+--------+--------------+-----------------------------------------+-------+---------+---------------+--------------+
deactivate offloading at veth of leaf switch in docker container 07e083e89d92
Actual changes:
tx-checksum-ip-generic: off
tx-tcp-segmentation: off [not requested]
tx-tcp6-segmentation: off [not requested]
deactivate offloading at veth of leaf switch in docker container 963b9defc90d
Actual changes:
tx-checksum-ip-generic: off
tx-tcp-segmentation: off [not requested]
tx-tcp6-segmentation: off [not requested]
docker-compose up --remove-orphans --force-recreate control-plane partition
ERROR: invalid reference format
make: *** [Makefile:48: up] Error 1

@Gerrit91
Copy link
Contributor Author

As the release vector PR and the backup-restore-sidecar were already merged, the overrides had to be removed.

@Gerrit91 Gerrit91 marked this pull request as ready for review September 26, 2023 07:18
@Gerrit91 Gerrit91 requested a review from a team as a code owner September 26, 2023 07:18
@Gerrit91 Gerrit91 requested a review from vknabel September 26, 2023 07:25
@Gerrit91 Gerrit91 merged commit 7db403d into master Sep 26, 2023
1 check passed
@Gerrit91 Gerrit91 deleted the migrate-to-meili-backup-restore branch September 26, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants